fix: don't mix Vite plugins when spawning temporary Vite server #6368
Conversation
🦋 Changeset detectedLatest commit: fdce124 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
We need the command, not the mode. |
|
for preview, integrations should take care, and for vite user plugins we should also filter them before starting Vite preview |
|
don't merge yet, preparing test |
|
We've another problem, when a plugin is included it can be excluded on sync call since we don't have command/action when using apply with function, we need to review it. You can check this line https://github.com/withastro/astro/blob/main/packages/astro/src/core/build/index.ts#L85, Astro creates vite for build then before run the build Astro creates a new config for sync. EDIT: seems to be ok now, I'll update the test again, I was using apply function arguments wrong 😬 ... |
| } else { | ||
| result = vite.mergeConfig(result, settings.config.vite || {}); | ||
| } | ||
| } |
There was a problem hiding this comment.
add else case without plugins?
Co-authored-by: Ben Holmes <hey@bholmes.dev>
Changes
Testing
Added simple test with disparate plugins for static build.
Docs
Bug fix only: maybe we need to add some hints for integrations registering plugins, check for example
@vite-pwa/astrointegration logic: https://github.com/vite-pwa/astro/blob/main/src/index.ts#L31